Remove `cleanupOnEntityDeleted` behavior

This issue has been created since 2022-06-22.

We currently have a beforeDelete rule that is not working correctly:

config.beforeDelete(["commitment"], async (cli) => {
  const commitment = cli.commitment.get;
  if (commitment) {
    if (!commitment.canBeEdited) {
      throw new Error("Cannot delete a Commitment Line Item on a signed commitment.");
    }
  }
});

Because when em.delete runs, we immediately clear the m2o relations, with the idea of making the object graph reflect the now-deleted state of the entity.

However, when beforeDelete runs, it means that m2o.get is now undefined.

It seems like we should leave the entity's relations alone, and lean on the other relation behavior of "filter deleted entities", which has the upshot of being able to be opted in/out of as well.

More Details About Repo
Owner Name stephenh
Repo Name joist-ts
Full Name stephenh/joist-ts
Language TypeScript
Created Date 2020-02-02
Updated Date 2022-08-28
Star Count 121
Watcher Count 7
Fork Count 9
Issue Count 67

YOU MAY BE INTERESTED

Issue Title Created Date Comment Count Updated Date
Support logseq as MD editor 3 2022-03-12 2022-05-15
add function to generate debug file 1 2022-01-13 2022-05-15
action to open MD note 1 2022-01-13 2022-05-15
add option to open note in default editor 3 2022-01-14 2022-05-15
Allow matching to notes not beginning with @ 16 2022-01-30 2022-05-15
The plugin is not working with the new Zotero 6.0-beta 2 2022-02-09 2022-05-15
Bug with the last update!!! 8 2022-01-18 2022-05-15
bug at startup of Zotero 10 2022-01-22 2022-05-15
Within cluster DE test 2 2022-03-22 2022-09-15
Model labels with commas malformed against models 1 2022-09-06 2022-09-19
Stability issues under slow Windows machines 4 2022-01-03 2022-09-18
Non-free ConvertUTF.c / ConvertUTF.h 3 2022-01-03 2022-09-18
开启自动缩进导致默认的comment header代码段也缩进 0 2021-11-05 2022-09-18
Smart HOME key problem 2 2021-11-17 2022-09-18
Functions not implemented 2 2022-01-26 2022-09-18
Can't correctly parse enum variable definition 0 2021-11-01 2022-09-18
NumPad Home and End keys don't work 1 2021-11-16 2022-09-18
Please refactor build system to follow FHS specification (install into $prefix instead of hardcoded /opt) 3 2022-01-04 2022-09-18
"Random Body" incompatible with bags other than the standard Backpack 0 2022-02-19 2022-09-15
bug: `Warning: mkdir(): File exists` on database build 2 2020-12-18 2022-08-13
How do I change lndo.site to something else - any dodumentation I can follow? 0 2022-07-13 2022-09-22
Bump gems periodically with GitHub Actions 0 2021-04-30 2022-09-09
Override keyboard input 0 2021-12-31 2022-08-05
Trigger 组件 点击触发节点隐藏右键菜单 0 2021-12-06 2022-08-25
Audio immediately crashes on windows 10 12 2022-07-28 2022-09-23
html and css lsp servers are running but no lsp completions 6 2021-07-08 2022-09-25
Interest in Web Animations API port ? 2 2019-08-17 2022-09-26
build a GUI/HUD to add or remove offmesh connections 0 2022-08-30 2022-09-26
Fix warning when running security scan 0 2021-12-13 2021-12-31
Is ReadBinary still a faster implementation of Next+copy under single node scenario? 4 2022-06-09 2022-09-26
Incorrect cursor position after css autocomplete 14 2022-03-04 2022-09-11
IntelliSense not working after updating vscode to 1.64 30 2022-02-04 2022-09-11
How can I get the val_loss value when training? 3 2022-04-29 2022-09-15
Hard reference to /usr/bin/ldd prevents usage on NixOS 0 2022-02-04 2022-08-07
JS object should be json unmarshalled into the target Go type 4 2020-03-10 2022-08-22
Does not support multiple targets 1 2019-07-24 2022-09-06
Add "CircuitPython" library issues and pull requests onto CircuitPython.org/contributing 0 2021-05-10 2022-09-17
我运行 examples/tensorflow/run.sh 后一直显示Application report for application_1612431077961_007(state:ACCEPTED) 1 2021-02-07 2022-09-26
Android Basics: ViewModel 0 2021-06-07 2022-08-21
Move errorprone checks into its own repository 1 2021-10-06 2022-09-05
Set right dry-schema version 0 2020-08-22 2022-09-04
[BUG] The value of `print()` in UDF apps doesn't show up in logs even when `show_log=True` 1 2022-01-21 2022-09-19
Chapter 20.3 Webserver Deadlock 1 2022-09-19 2022-09-22
Biased choice of language in UTF8 examples results in unneseccary explanations 3 2022-09-16 2022-09-22
Add a setting to configure `X-Frame-Options` / `Content-Security-Policy` headers 1 2022-08-05 2022-08-06
ipywidgets not capturing user input correctly after May update 2 2022-06-10 2022-08-27
Features: background color of the title bar; width of <label>; 0 2021-02-19 2022-07-25
Template building failure at "Building wheels for collected packages: typed-ast" 2 2020-04-02 2022-09-28
Unable to archive app for distribution using Xcode 12.5.1 and Swift Package Manager 7 2021-10-20 2022-09-15
Render could not be removed from theme by running the script. Internal Server Error with id - c651d43d-0b69-4212-9a38-cef70f14c044 1 2022-07-20 2022-09-26