[Impeller] Remove TargetPlatform::kFlutterSPIRV in the shader compiler.

This issue has been created since 2022-09-22.

This was necessary when we had a runtime conversion from SPIRV to SKSL in the engine. But now, ImpellerC can generated SKSL directly. So there is no need to have this path which has optimizations disabled due to the incorrect OpPhi handling.

We should remove this and also enable optimizations in the generated SKSL that seem to be disabled for no reason even now.

chinmaygarde wrote this answer on 2022-09-23

cc @zanderso @dnfield @jonahwilliams. We should be able to get rid of this option and enabled SKSL optimizations now that we have an SKSL path right?

jonahwilliams wrote this answer on 2022-09-23

Yes, all of the tooling paths are converted to provided SkSL now.

zanderso wrote this answer on 2022-09-24

Even after this we may still need to play around with the backend options to avoid generating things SkSL doesn't support when optimizations are enabled: https://bugs.chromium.org/p/skia/issues/detail?id=13518.

chinmaygarde wrote this answer on 2022-09-24

Roger. Presumably, the SKSL processing at runtime will apply the same optimizations.

More Details About Repo
Owner Name flutter
Repo Name flutter
Full Name flutter/flutter
Language Dart
Created Date 2015-03-06
Updated Date 2022-10-05
Star Count 145516
Watcher Count 3569
Fork Count 23400
Issue Count 11194

YOU MAY BE INTERESTED

Issue Title Created Date Comment Count Updated Date
Resolving nested Target reference fails in partial reactor build 7 2022-07-28 2022-09-05
No scene.pkg file found when one is clearly there 2 2022-02-02 2022-10-05
Whitelabeler for mautic version 3.3.5 1 2022-03-11 2022-09-20
folder permission problem 1 2022-04-02 2022-09-20
Whitelabeler for version 4.2.0 1 2022-03-10 2022-09-20
AttributeError: 'AnnAssign' object has no attribute 'targets' 1 2022-01-04 2022-05-26
test_parse_function_call_as_name and test_repo_line fail on openSUSE 2 2021-12-01 2022-05-26
Make linux/arm64 a tier 1 platform for clients, tools and workers 2 2022-02-22 2022-02-25
initial_world_transform() and zed.get_position() have different results. 2 2022-07-18 2022-09-12
Why seek operations in MediaSessionActionDetails are both nullable and optioanal? 1 2020-03-23 2022-10-02
How do I trigger the per-field validation chain when ANY field changes on the form? 0 2021-08-02 2022-09-20
docs/InstallFlinkx.md 这个文档404了,连接是不是更新了?? 0 2021-03-18 2022-08-31
Manage Team Policies: Global maintainer ability to Add a team policy 3 2022-02-17 2022-09-20
Parser bug for left/right shift 0 2022-09-22 2022-10-03
Doc: the build_and_run.md is outdated 0 2022-05-06 2022-10-02
PlatformIndependentEnvironment does not convey its role 3 2022-06-15 2022-09-18
Fullscreen documentation + mobile pinch zoom 4 2021-01-20 2022-09-16
PageHelper.startPage(pageNum, pageSize);当pageNum=0 和 pageNum=1查询出来的结果相同 2 2018-09-20 2022-09-23
Additional Kochava domains 4 2021-09-06 2022-09-03
Check execution is in some cases very slow 2 2020-12-11 2022-09-19
[ERROR] user#signin (ActionController::InvalidAuthenticityToken) "ActionController::InvalidAuthenticityToken" 5 2019-11-01 2022-09-05
Speakerphone icon on Conversations, Cheogram, or Monocles does not work. External speaker on all the time. 0 2022-03-20 2022-09-24
Getting information out of RestClient Request 1 2022-04-27 2022-09-02
Dependency Dashboard 0 2021-10-18 2022-09-20
WDL Devtools for VSCode rendering non-breaking whitespace causing errors 5 2021-08-01 2022-08-28
Deployment Resetting While running 'npm ci && npm run build' 4 2021-09-18 2022-09-18
[Security] Potential Secret Leak 1 2021-04-24 2022-08-18
Add youtuber's playlist tab. 1 2022-09-20 2022-09-26
Shorts videos tagged as live feed 0 2022-09-20 2022-09-26
Possible missing @clr/core 4.0.16? 1 2022-03-15 2022-09-21
[Termux] not installing modules 0 2022-09-16 2022-09-30
Some songs will not download 1 2022-01-17 2022-09-20
Integrations tests system 1 2018-09-20 2021-10-10
--- stderr: moveit_msgs No 'rosidl_typesupport_c' found 1 2021-04-29 2022-01-10
test-network-in-a-box 2 2022-02-07 2022-08-27
[alpha122] Failed to process revocation notification message 1 2022-06-15 2022-08-30
Reporobot doesn't have access to the fork. 0 2021-01-29 2022-09-20
Error while creating an Azure virtual machine 2 2022-07-14 2022-09-28
bug: Buttons inside IonModal are not clickable 3 2022-03-04 2022-10-02
storage: Add Support for Dual Region Buckets 0 2022-03-23 2022-07-21
python.execInTerminal-icon' not found 8 2021-05-28 2022-09-27
Blank page after login on ssl 8 2021-07-31 2022-09-27
loop sometimes returns positive when there was no data 2 2011-09-13 2022-09-26
Changes for code readability 1 2022-05-04 2022-09-26
Store `api_key` as Environmental Variable 1 2022-08-02 2022-09-26
Is Windows not able to right-click to paste remotely? 2 2022-03-21 2022-09-09
Blockbase/Attar: Hide Footer Credit Leaves a Visible Empty Group Block Below Footer 8 2022-05-30 2022-09-24
[RFC][Tracking Issue] TensorIR Scheduling 11 2021-02-24 2022-08-26
AttributeError: 'dict' object has no attribute 'iterkeys' 3 2017-07-15 2022-09-26
Cafe-dsl sample not working 2 2017-02-13 2022-08-23