hotReloadVMReloadMillisecondsAfterChange - Hot reload time increase from 50 to 51

This issue has been created since 2022-09-22.

This benchmark was extremely stable.

image

Seems to have increased with: flutter/engine#36315

Another benchmark that increased:

hotReloadVMReloadMillisecondsAfterLargeChange

image

cc: @a-siva , @zanderso

iskakaushik wrote this answer on 2022-09-22

Not sure if this should be a P0 given the minor increase, but marking it so per policy of benchmark regression.

a-siva wrote this answer on 2022-09-23

This seems to be the set of changes in the Dart roll https://dart.googlesource.com/sdk.git/+log/33c0f62f0964..7f7b7f28120f

From this set there are only three VM changes

  • 9598547 [VM/Library] - Adjust next probe to be a quadratic probe in _HashBase by asiva · 2 days ago
  • 7f40a29 [vm] Fix debug/arm64c build by Alexander Markov · 2 days ago
  • 83ab5d5 [vm] Remove dynamic field unboxing in JIT by Vyacheslav Egorov · 2 days ago

I don't believe the debug/arm64c build fix change could have caused it.

Need to check the other two changes to see if they could have made a difference, I am suspecting the quadratic probe change could have caused it. I will revert it and see if that fixes it.

a-siva wrote this answer on 2022-09-23

I have created a revert CL here https://dart-review.googlesource.com/c/sdk/+/260747, once it lands and rolls into Flutter we can recheck and see if the regression here is addressed.

a-siva wrote this answer on 2022-10-01

It appears that the minor regression is due to 83ab5d5 [vm] Remove dynamic field unboxing in JIT
This CL is a nice refactoring and I don't believe should be reverted.
At this point I am inclined to take the minor regression if folks here agree.

More Details About Repo
Owner Name flutter
Repo Name flutter
Full Name flutter/flutter
Language Dart
Created Date 2015-03-06
Updated Date 2022-10-05
Star Count 145512
Watcher Count 3569
Fork Count 23398
Issue Count 11205

YOU MAY BE INTERESTED

Issue Title Created Date Comment Count Updated Date
Scenario Level reporting 10 2021-09-01 2022-08-07
dbus-broker.service needs a dependency After=systemd-sysusers.service 8 2021-06-18 2022-07-26
[BUG] Baron timer, elder timer, inhibitor timers is not showing 15 2021-10-10 2022-07-24
dragon timer, herald and baron [FEATURE] 0 2021-10-09 2022-04-03
Module 'osqp' has no attribute 'solve'. 1 2021-09-13 2022-10-05
Missing `$consumer->consume` from consumer documentation 0 2022-08-22 2022-09-05
[QUESTION] Support SSL Authentication for Consumer? 2 2022-08-15 2022-09-05
`-DPETIBM_BUILD_YAMLCPP` failure 0 2022-05-22 2022-09-23
Adding a listing to see sessions or 3 last used files? 2 2021-12-20 2022-08-29
[Bug]: BufferlinePick with unnamed buffers 2 2022-04-16 2022-09-24
Add 'utf8Size' opcode 4 2021-10-07 2022-07-16
[BUG] Removing Tailwind breaks HMR 4 2022-09-07 2022-09-27
Login to account in monero-gui doesn't work - returns "Please check your login details" 0 2021-03-05 2022-08-01
Error-Message 0 2021-10-26 2022-01-02
GatewayBalances 2 2021-12-22 2022-01-19
Sharp Fails to Install on Ubuntu 20.04 10 2022-03-21 2022-08-09
Cookies valid but there is an error 2 2021-03-24 2022-09-20
Remove unsupported field when specifying "gp2" volume type 3 2018-02-09 2022-10-05
Disabling Rewrite Mod and Using query strings instead 0 2022-02-09 2022-09-10
Spotify episodes throw an error 0 2021-04-23 2022-09-23
Executing Custom Commands 0 2021-07-01 2022-09-10
Also test PHP 8.0 and 8.1/8.2 pre-releases in CI 1 2021-10-01 2022-10-03
Remove deprecated code 36 2022-04-22 2022-09-28
Release version 0.4.0 2 2022-01-28 2022-07-16
Restore the ability to collapse "Request" section in Graph Explorer 2 2021-11-29 2022-09-22
Fix OpenApiRenderer list could be null 4 2021-09-28 2022-08-30
Unit tests for `validate_images` 2 2022-08-10 2022-09-26
input file operator: error file already closed 4 times for each file 2 2021-12-02 2022-04-30
release-21.2: server: VIEWACTIVITY role gates unredacted nodes info 0 2022-03-23 2022-09-24
Minor update to the background section 0 2021-01-15 2022-09-17
cors error on all of them 2 2022-02-15 2022-09-28
Elaborate what ApiControllerAttribute does 0 2019-02-19 2022-10-04
Add request context 5 2021-10-07 2022-01-14
[Bug]: Console.assert errors 5 2022-08-22 2022-08-23
Release v1.8.0 9 2022-01-03 2022-01-16
Migrating to 14.6.1 uses rc packages 1 2022-08-31 2022-09-07
Nx 14.6.x causes @nrwl/next to incorrectly resolve dependency versions 0 2022-09-01 2022-09-07
Table\Column\FilterModel throws error on json type fields 0 2022-03-03 2022-08-17
LoadError when starting msfconsole for the first time 3 2021-12-28 2022-10-05
[docs] torchvision.ops.roi_pool doesn't mention dtype of boxes tensor 0 2021-11-01 2022-09-16
images are not responsive 1 2020-04-08 2022-08-31
how to change font of toast? 7 2018-12-20 2022-09-22
Issue on repository for Ubuntu 20.04 10 2021-01-25 2022-09-25
NVIDIA_VISIBLE_DEVICES= does not work with device index 7 2020-09-01 2022-09-25
ColorAnimationUsingKeyFrames does not work on GradientBrush 0 2022-09-09 2022-10-03
ePub format requested 0 2021-01-14 2022-09-27
formatting does not match ruby standards 2 2020-08-31 2022-09-13
Brave Wallet image / vector shows anti-aliasing or rendering artifacts 0 2022-04-21 2022-07-09
Not working with formlogin? 4 2019-10-25 2022-09-30
ActionMailer deliver_now and deliver_later arguments 4 2022-02-03 2022-10-05